Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack for actix-web and actori-web #81174

Closed
wants to merge 1 commit into from
Closed

Remove hack for actix-web and actori-web #81174

wants to merge 1 commit into from

Conversation

Aaron1011
Copy link
Member

Hopefully, most affected crates have run cargo update by now. If not,
I'll explore phasing this out gradually.

r? @ghost

@Aaron1011
Remove hack for actix-web and actori-web
0153f7d 
Hopefully, most affected crates have run `cargo update` by now. If not,
I'll explore phasing this out gradually.
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 18, 2021

⌛ Trying commit 0153f7d with merge f5e1d18a431fc2bb12c57c3144ce68e79f06b514...

@bors
Copy link
Contributor

bors commented Jan 18, 2021

☀️ Try build successful - checks-actions
Build commit: f5e1d18a431fc2bb12c57c3144ce68e79f06b514 (f5e1d18a431fc2bb12c57c3144ce68e79f06b514)

@Aaron1011
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-81174 created and queued.
🤖 Automatically detected try build f5e1d18a431fc2bb12c57c3144ce68e79f06b514
⚠️ Try build based on commit 5e91c4e, but latest commit is 0153f7d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 18, 2021
@ThePuzzlemaker
Copy link
Contributor

Huh. I’m curious. When exactly was this introduced and why?

@Aaron1011
Copy link
Member Author

Aaron1011 commented Jan 19, 2021 •
edited by petrochenkov
Loading

@ThePuzzlemaker This was introduced in 9a6ea38, as part of #77135. That PR made us preserve the original TokenStream in more cases, making progress towards fixing the longstanding compiler bug #43081.

Unfortunately, this change broke actix-web and actori-web, since they used an older version of syn that was not prepared to handle the None-delimited groups present in the new TokenStream input. As a result, I added this hack to allow those crates to continue to compile, while still allowing us to preserve Spans in the input TokenStream.

However, having the compiler special-case certain filenames is a really awful hack. I'd like to get rid of this as soon as possible - unfortunately, there may be a large number of Cargo.lock files onGitHub that need to be updated.

@pietroalbini
Copy link
Member

@craterbot run start=master#5e91c4ecc09312d8b63d250a432b0f3ef83f1df7 end=try#5e91c4ecc09312d8b63d250a432b0f3ef83f1df7 mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-81174 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Aaron1011
Copy link
Member Author

@pietroalbini It looks like you specified the same start and end commit?

@Aaron1011
Copy link
Member Author

@craterbot abort

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-81174 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 23, 2021
@Aaron1011
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jan 23, 2021

⌛ Trying commit 0153f7d with merge 9cfe725f0995b018340c519db1b2f3cf8a7e0631...

@bors
Copy link
Contributor

bors commented Jan 23, 2021

☀️ Try build successful - checks-actions
Build commit: 9cfe725f0995b018340c519db1b2f3cf8a7e0631 (9cfe725f0995b018340c519db1b2f3cf8a7e0631)

@Aaron1011
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-81174 created and queued.
🤖 Automatically detected try build 9cfe725f0995b018340c519db1b2f3cf8a7e0631
⚠️ Try build based on commit 4d0dd02, but latest commit is 0153f7d. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

2 similar comments
@craterbot
Copy link
Collaborator

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-81174 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-81174 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

Sorry about that. A new crater deployment broke a thing. Should be fixed now.

@craterbot retry p=3

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-81174 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

@craterbot p=3

@craterbot
Copy link
Collaborator

📝 Configuration of the pr-81174 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-81174 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-81174 is completed!
📊 394 regressed and 9 fixed (142067 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 29, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@crlf0710
Copy link
Member

Ping from triage @Aaron1011 : it seems some crates like actix-web 2.0.0 and actix-web 3.0.0 still regresses after this change. What's next steps here?

@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2021
@Aaron1011
Copy link
Member Author

The actori-web hack was removed entirely, and we are now linting whenver we apply the actix-web hack.

@Aaron1011 Aaron1011 closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Aaron1011 @bors @craterbot @ThePuzzlemaker @pietroalbini @crlf0710 @JohnCSimon